Re: libpq's multi-threaded SSL callback handling is busted - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: libpq's multi-threaded SSL callback handling is busted
Date
Msg-id 55249A5E.6050206@gmx.net
Whole thread Raw
In response to Re: libpq's multi-threaded SSL callback handling is busted  (Jan Urbański <wulczer@wulczer.org>)
Responses Re: libpq's multi-threaded SSL callback handling is busted
List pgsql-hackers
On 4/3/15 7:44 AM, Jan Urbański wrote:
> To reiterate: I recognise that not handling the callbacks is not the right
> answer. But not stomping on callbacks others might have set sounds like a
> minimal and safe improvement.

I think your patch is okay in that it is not a good idea to overwrite or
unset someone else's callbacks.  But we shouldn't mistake that for
fixing the underlying problem.  The only reason this patch appears to
fix the presented test cases is because other OpenSSL users are also
misbehaving and/or the OpenSSL interfaces are so stupid that they cannot
be worked with reasonably.





pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: "rejected" vs "returned with feedback" in new CF app
Next
From: Michael Paquier
Date:
Subject: Re: "rejected" vs "returned with feedback" in new CF app