Re: patch : Allow toast tables to be moved to a different tablespace - Mailing list pgsql-hackers

From Andreas Karlsson
Subject Re: patch : Allow toast tables to be moved to a different tablespace
Date
Msg-id 550B5CBE.3020601@proxel.se
Whole thread Raw
In response to Re: patch : Allow toast tables to be moved to a different tablespace  (Julien Tachoires <julmon@gmail.com>)
Responses Re: patch : Allow toast tables to be moved to a different tablespace  (Julien Tachoires <julmon@gmail.com>)
List pgsql-hackers
On 03/19/2015 04:55 PM, Julien Tachoires wrote:
> On 18/03/2015 19:54, Andreas Karlsson wrote:
>> Looks good but I think one minor improvement could be to set the table
>> space of the toast entires to the same as the tablespace of the table to
>> reduce the amount of "SET default_tablespace". What do you think?
>
> Yes, you're right, some useless "SET default_tablespace" were added for
> each ALTER TABLE SET TOAST TABLESPACE statement. It's now fixed with
> this new patch. Thanks.

I am confused by your fix. Wouldn't cleaner fix be to use
tbinfo->reltablespace rather than tbinfo->reltoasttablespace when
calling ArchiveEntry()?

I tried the attached path and it seemed to work just fine.

--
Andreas Karlsson

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] two-arg current_setting() with fallback
Next
From: Andreas Karlsson
Date:
Subject: Re: Using 128-bit integers for sum, avg and statistics aggregates