Re: Patch: raise default for max_wal_segments to 1GB - Mailing list pgsql-hackers

From Josh Berkus
Subject Re: Patch: raise default for max_wal_segments to 1GB
Date
Msg-id 54F5FBAC.4000600@agliodbs.com
Whole thread Raw
In response to Patch: raise default for max_wal_segments to 1GB  (Josh Berkus <josh@agliodbs.com>)
Responses Re: Patch: raise default for max_wal_segments to 1GB  (Heikki Linnakangas <hlinnaka@iki.fi>)
Re: Patch: raise default for max_wal_segments to 1GB  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 03/03/2015 10:15 AM, Josh Berkus wrote:
> On 03/02/2015 11:25 PM, Heikki Linnakangas wrote:
>> I propose that we remove the comment from max_wal_size, and also remove
>> the "in milliseconds" from wal_receiver_timeout and
>> autovacuum_vacuum_cost_delay.
> 
> +1
> 

Actually, let's be consistent about this.  It makes no sense to remove
unit comments from some settings which accept ms but not others.

Do we want to remove unit comments from all settings which accept
"MB,GB" or "ms,s,min"?  There's more than a few.  I'd be in favor of
this, but seems like (a) it should be universal, and (b) its own patch.

-- 
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com



pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Re: Patch: raise default for max_wal_segments to 1GB
Next
From: Josh Berkus
Date:
Subject: Re: Comparing primary/HS standby in tests