Re: TABLESAMPLE patch - Mailing list pgsql-hackers

From Petr Jelinek
Subject Re: TABLESAMPLE patch
Date
Msg-id 54C8BB13.3020901@2ndquadrant.com
Whole thread Raw
In response to Re: TABLESAMPLE patch  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
List pgsql-hackers
On 28/01/15 08:23, Kyotaro HORIGUCHI wrote:
> Hi, I took a look on this and found nice.
>
> By the way, the parameter for REPEATABLE seems allowing to be a
> expression in ParseTableSample but the grammer rejects it.
>

It wasn't my intention to support it, but you are correct, the code is 
generic enough that we can support it.

> The following change seems enough.
>

Seems about right, thanks.


--  Petr Jelinek                  http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Petr Jelinek
Date:
Subject: Re: TABLESAMPLE patch
Next
From: Andres Freund
Date:
Subject: Re: Misaligned BufferDescriptors causing major performance problems on AMD