Re: [RFC] LSN Map - Mailing list pgsql-hackers

From Jim Nasby
Subject Re: [RFC] LSN Map
Date
Msg-id 54AED804.7060701@BlueTreble.com
Whole thread Raw
In response to [RFC] LSN Map  (Marco Nenciarini <marco.nenciarini@2ndquadrant.it>)
Responses Re: [RFC] LSN Map
List pgsql-hackers
On 1/7/15, 3:50 AM, Marco Nenciarini wrote:
> The current implementation tracks only heap LSN. It currently does not
> track any kind of indexes, but this can be easily added later.

Would it make sense to do this at a buffer level, instead of at the heap level? That means it would handle both heap
andindexes. I don't know if LSN is visible that far down though.
 

Also, this pattern is repeated several times; it would be good to put it in it's own function:
+         lsnmap_pin(reln, blkno, &lmbuffer);
+         lsnmap_set(reln, blkno, lmbuffer, lsn);
+         ReleaseBuffer(lmbuffer);
-- 
Jim Nasby, Data Architect, Blue Treble Consulting
Data in Trouble? Get it in Treble! http://BlueTreble.com



pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: Possible typo in create_policy.sgml
Next
From: Jim Nasby
Date:
Subject: Re: VODKA?