Re: Review of Refactoring code for sync node detection - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Review of Refactoring code for sync node detection
Date
Msg-id 548AE1C7.3070508@vmware.com
Whole thread Raw
In response to Re: Review of Refactoring code for sync node detection  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Review of Refactoring code for sync node detection  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On 12/12/2014 04:29 AM, Michael Paquier wrote:
> On Thu, Dec 11, 2014 at 10:07 PM, Heikki Linnakangas <
> hlinnakangas@vmware.com> wrote:
>
>> I propose the attached (I admit I haven't tested it).
>>
> Actually if you do it this way I think that it would be worth adding the
> small optimization Fujii-san mentioned upthread: if priority is equal to 1,
> we leave the loop earlier and return immediately the pointer. All those
> things gathered give the patch attached, that I actually tested FWIW with
> multiple standbys and multiple entries in s_s_names.

Ok, committed.

- Heikki



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: logical column ordering
Next
From: Michael Paquier
Date:
Subject: Re: Review of Refactoring code for sync node detection