On 12/05/2014 08:03 PM, David Rowley wrote:
> On 2 December 2014 at 15:36, Craig Ringer <craig@2ndquadrant.com
> <mailto:craig@2ndquadrant.com>> wrote:
>
> On 12/01/2014 09:51 PM, Marco Nenciarini wrote:
> > I think this is a leftover, as you don't use elog afterwards.
>
> Good catch, fixed.
>
> I've looked over this again and tested it on a windows 8.1 machine. I
> cannot find any problems
>
> The only comments about the code I have would maybe be to use some
> constants like:
>
> #define FILETIME_PER_SEC10000000L
> #define FILETIME_PER_USEC10
[snip]
> I'll leave it up to the committer to decide if it's better with or
> without the attached patch.
I think it's more readable, and that's pretty much always a good thing.
Patches with your changes attached.
I used FILETIME_UNITS_PER_SEC though.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
