Re: proposal - function string_to_table - Mailing list pgsql-hackers

From Tom Lane
Subject Re: proposal - function string_to_table
Date
Msg-id 547149.1599098390@sss.pgh.pa.us
Whole thread Raw
In response to Re: proposal - function string_to_table  (Peter Smith <smithpb2250@gmail.com>)
List pgsql-hackers
Peter Smith <smithpb2250@gmail.com> writes:
> On Thu, Sep 3, 2020 at 8:30 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> The proposed tests seemed mighty duplicative, and they even contained
>> syntax errors, so I didn't believe that they were carefully considered.

> Can you please share examples of what syntax errors were in those
> previous tests?

At about line 415 of string_to_table-20200825.patch:

+select v, v is null as "is null" from string_to_table('1,2,3,4,,6', ',') g(v) g(v);
+ERROR:  syntax error at or near "g"
+LINE 1: ..."is null" from string_to_table('1,2,3,4,,6', ',') g(v) g(v);
+                                                                  ^

Without the duplicate "g(v)", this is identical to the preceding test
case.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: proposal - function string_to_table
Next
From: Michael Paquier
Date:
Subject: Re: Refactor ReindexStmt and its "concurrent" boolean