Re: pg_basebackup fails with long tablespace paths - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: pg_basebackup fails with long tablespace paths
Date
Msg-id 545D79DB.4060507@gmx.net
Whole thread Raw
In response to Re: pg_basebackup fails with long tablespace paths  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: pg_basebackup fails with long tablespace paths  (Oskari Saarenmaa <os@ohmu.fi>)
Re: pg_basebackup fails with long tablespace paths  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On 11/4/14 3:52 PM, Peter Eisentraut wrote:
> Here are patches to address that.  First, it reports errors when
> attempting to create a tar header that would truncate file or symlink
> names.  Second, it works around the problem in the tests by creating a
> symlink from the short-name tempdir that we had set up for the
> Unix-socket directory case.

I ended up splitting this up differently.  I applied to part of the
second patch that works around the length issue in tablespaces.  So the
tests now pass in 9.4 and up even in working directories with long
names.  This clears up the regression in 9.4.

The remaining, not applied patch is attached.  It errors when the file
name is too long and adds tests for that.  This could be applied to 9.5
and backpatched, if we so choose.  It might become obsolete if
https://commitfest.postgresql.org/action/patch_view?id=1512 is accepted.
 If that patch doesn't get accepted, I might add my patch to a future
commit fest.


Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: pg_multixact not getting truncated
Next
From: Robert Haas
Date:
Subject: Re: tracking commit timestamps