Re: pgcrypto: PGP signatures - Mailing list pgsql-hackers

From Marko Tiikkaja
Subject Re: pgcrypto: PGP signatures
Date
Msg-id 544ED8CA.9040206@joh.to
Whole thread Raw
In response to Re: pgcrypto: PGP signatures  (Jeff Janes <jeff.janes@gmail.com>)
Responses Re: pgcrypto: PGP signatures
List pgsql-hackers
On 10/27/14, 11:57 PM, Jeff Janes wrote:
> Using the same script as for the memory leak, I am getting seg faults using
> this patch.
>
> gdb backtrace:
>
> #0  pfree (pointer=0x0) at mcxt.c:749
> #1  0x00007f617d7973e7 in pgp_sym_decrypt_verify_text (fcinfo=0x1d7f1f0) at
> pgp-pgsql.c:1047

Huh.  That's weird.  I seem to have somehow rebased an older version of
the patch from my git history.  This is the copy-paste mistake Thomas
(IIRC) pointed out and I fixed weeks, if not months, ago.

I have no idea what happened so I just threw away the git history and
rebased v6 of the patch on top of master.  I've also verified that the
script runs and does not leak memory.  The resulting patch, v8, attached.

My apologies for wasting your time, but thanks for testing!


.marko

Attachment

pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: Directory/File Access Permissions for COPY and Generic File Access Functions
Next
From: Tomas Vondra
Date:
Subject: Re: proposal: CREATE DATABASE vs. (partial) CHECKPOINT