On 10/23/14, 6:23 PM, Alvaro Herrera wrote:
> Brightwell, Adam wrote:
>
>>> If we were to make it consistent and use the old wording, what do you
>>> think about providing an "errhint" as well?
>>>
>>> Perhaps for example in slotfuncs.c#pg_create_physical_replication_stot:
>>>
>>> errmsg - "permission denied to create physical replication slot"
>>> errhint - "You must be superuser or replication role to use replication slots."
>
> Sure.
>
>> As I started looking at this, there are multiple other places where
>> these types of error messages occur (opclasscmds.c, user.c,
>> postinit.c, miscinit.c are just a few), not just around the changes in
>> this patch. If we change them in one place, wouldn't it be best to
>> change them in the rest? If that is the case, I'm afraid that might
>> distract from the purpose of this patch. Perhaps, if we want to
>> change them, then that should be submitted as a separate patch?
>
> Yeah. I'm just saying that maybe this patch should adopt whatever
> wording we agree to, not that we need to change other places. On the
> other hand, since so many other places have adopted the different
> wording, maybe there's a reason for it and if so, does anybody know what
> it is. But I have to say that it does look inconsistent to me.
Keep in mind that originally the ONLY special permissions "thing" we had was rolsuper. Now we also have replication,
maybesome others, and there's discussion of adding a special "backup role".
In other words, the situation is a lot more complex than it used to be. So if cleanup is done here, it would be best to
tryand account for this new stuff.
--
Jim Nasby, Data Architect, Blue Treble Consulting
Data in Trouble? Get it in Treble! http://BlueTreble.com
