Incorrect comment in tablecmds.c - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Incorrect comment in tablecmds.c
Date
Msg-id 5448CA63.80602@lab.ntt.co.jp
Whole thread Raw
Responses Re: Incorrect comment in tablecmds.c
List pgsql-hackers
I don't think that the lock level mentioned in the following comment in
MergeAttributes() in tablecmds.c is right, since that that function has
opened the relation with ShareUpdateExclusiveLock, not with
AccessShareLock.  Patch attached.

1749         /*
1750          * Close the parent rel, but keep our AccessShareLock on it
until xact
1751          * commit.  That will prevent someone else from deleting or
ALTERing
1752          * the parent before the child is committed.
1753          */
1754         heap_close(relation, NoLock);

Thanks,

Best regards,
Etsuro Fujita

Attachment

pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: BUG: *FF WALs under 9.2 (WAS: .ready files appearing on slaves)
Next
From: Pavel Stehule
Date:
Subject: Re: idea: allow AS label inside ROW constructor