Re: inherit support for foreign tables - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: inherit support for foreign tables
Date
Msg-id 543F7639.300@lab.ntt.co.jp
Whole thread Raw
In response to Re: inherit support for foreign tables  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Responses Re: inherit support for foreign tables
List pgsql-hackers
(2014/08/28 18:00), Etsuro Fujita wrote:
> (2014/08/22 11:51), Noah Misch wrote:
>> Today's ANALYZE VERBOSE messaging for former inheritance parents
>> (tables with
>> relhassubclass = true but no pg_inherits.inhparent links) is
>> deceptive, and I
>> welcome a fix to omit the spurious message.  As defects go, this is quite
>> minor.  There's fundamentally no value in collecting inheritance tree
>> statistics for such a parent, and no PostgreSQL command will do so.

>> A
>> credible alternative is to emit a second message indicating that we
>> skipped
>> the inheritance tree statistics after all, and why we skipped them.

> I'd like to address this by emitting the second message as shown below:

> A separate patch (analyze.patch) handles the former case in a similar way.

I'll add to the upcoming CF, the analyze.patch as an independent item,
which emits a second message indicating that we skipped the inheritance
tree statistics and why we skipped them.

Thanks,

Best regards,
Etsuro Fujita

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: WIP: dynahash replacement for buffer table
Next
From: Pavel Stehule
Date:
Subject: Re: proposal: plpgsql - Assert statement