Re: [PATCH] Rename "getdatabaseencoding()" to "pg_database_encoding()", and document - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: [PATCH] Rename "getdatabaseencoding()" to "pg_database_encoding()", and document
Date
Msg-id 540A1172-161A-48CC-8827-BF89AFA156AC@yesql.se
Whole thread
Responses Re: [PATCH] Rename "getdatabaseencoding()" to "pg_database_encoding()", and document
Re: [PATCH] Rename "getdatabaseencoding()" to "pg_database_encoding()", and document
List pgsql-hackers
> On 17 Jul 2026, at 08:44, Ian Lawrence Barwick <barwick@gmail.com> wrote:

> It was noted here [1] that we have the undocumented SQL function
> "getdatabaseencoding()", used mainly in regression tests and a couple
> of psql queries. While considering a documentation patch, it occurred
> to me that it's a horrible function name which doesn't look like other
> public functions, and we already have "pg_client_encoding()", so why not
> rename it to match that while we're at it?

This function seems to be referred to in extensions, how about adding keeping
the existin name and adding the new name as an alias?  It would keep existing
code from breaking and cause less churn in the code.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: sequencesync worker race with REFRESH SEQUENCES
Next
From: Masahiko Sawada
Date:
Subject: Re: Follow-up fixes for online wal_level change