Re: WAL format and API changes (9.5) - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: WAL format and API changes (9.5)
Date
Msg-id 5405B6B4.6040300@vmware.com
Whole thread Raw
In response to Re: WAL format and API changes (9.5)  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: WAL format and API changes (9.5)  (Michael Paquier <michael.paquier@gmail.com>)
Re: WAL format and API changes (9.5)  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On 08/19/2014 05:38 PM, Andres Freund wrote:
> On 2014-08-19 10:33:29 -0400, Alvaro Herrera wrote:
>> Heikki Linnakangas wrote:
>>
>>> Barring objections or better ideas, I'm leaning towards
>>> XLogReadBufferForRedo.
>>
>> WFM
>
> for me too. Although we could imo strip the 'XLog' in the beginning if
> we want to make it shorter. The ForRedo is saying that pretty much.

I committed the redo-routine refactoring patch. I kept the XLog prefix 
in the XLogReadBufferForRedo name; it's redundant, but all the other 
similar functions in xlogutils.c use the XLog prefix so it would seem 
inconsistent to not have it here.

I'll post a new version of the main patch shortly...

- Heikki




pgsql-hackers by date:

Previous
From: Joel Jacobson
Date:
Subject: Re: PL/pgSQL 2
Next
From: Heikki Linnakangas
Date:
Subject: Re: PL/pgSQL 2