Re: pg_dump refactor patch to remove global variables - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: pg_dump refactor patch to remove global variables
Date
Msg-id 53FCAA85.8030104@gmx.net
Whole thread Raw
In response to pg_dump refactor patch to remove global variables  (Joachim Wieland <joe@mcknight.de>)
Responses Re: pg_dump refactor patch to remove global variables
List pgsql-hackers
On 8/15/14 7:30 PM, Joachim Wieland wrote:
> Attached is a patch that doesn't add any new functionality or
> features, all it does is get rid of the global variables that
> pg_dump.c is full of.

I'm getting a compiler error:

In file included from pg_dump.c:60:
In file included from ./pg_backup_archiver.h:32:
./pg_backup.h:212:3: error: redefinition of typedef 'DumpOptions' is a
C11 feature [-Werror,-Wtypedef-redefinition]
} DumpOptions; ^
./pg_dump.h:507:29: note: previous definition is here
typedef struct _dumpOptions DumpOptions;                           ^
1 error generated.




pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Scaling shared buffer eviction
Next
From: Alvaro Herrera
Date:
Subject: Re: Per table autovacuum vacuum cost limit behaviour strange