On 08/11/2014 12:22 AM, MauMau wrote:
> From: "Vik Fearing" <vik.fearing@dalibo.com>
>> On 08/10/2014 03:24 PM, MauMau wrote:
>>> Could you also improve the doc by changing "table" to "relation" in the
>>> description of get_raw_page()? Having a quick look at the code, it
>>> seems that the function can also handle indexes.
>>>
>>> table and returns a copy as a <type>bytea</> value. This
>>> allows a
>>
>>
>> Good catch. I wasn't sure whether using "relation" or "table or index"
>> was better, but after a quick test it seems it works for sequences, too,
>> so I've gone with "relation".
>>
>> It doesn't work with views, of course, but it does work with
>> materialized views.
>>
>> Modified patch attached.
>
> Thanks, I marked this as ready for committer.
>
> I think I'll leave it up to you to decide whether you improve the HINT
> message Fujii-san pointed out, which is in src/backend/catalog/catalog.c.
I think you're looking at an old version of the code. My understanding
of his message was that that patch had already been applied but not
backpatched and he wants it backpatched. To wit, that hint message does
include "init" on master and it's located in src/common/relpath.c.
However, I did find another occurence in the documentation, so third
patch attached.
--
Vik
