Re: [COMMITTERS] pgsql: Move log_newpage and log_newpage_buffer to xlog.c. - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: [COMMITTERS] pgsql: Move log_newpage and log_newpage_buffer to xlog.c.
Date
Msg-id 53DA5728.6070002@iki.fi
Whole thread Raw
Responses Re: [COMMITTERS] pgsql: Move log_newpage and log_newpage_buffer to xlog.c.  (Simon Riggs <simon@2ndQuadrant.com>)
List pgsql-hackers
On 07/31/2014 05:19 PM, Simon Riggs wrote:
> On 31 July 2014 14:59, Heikki Linnakangas <heikki.linnakangas@iki.fi> wrote:
>
>> Move log_newpage and log_newpage_buffer to xlog.c.
>
> Got a feeling this wasn't properly discussed because its unlikely
> anybody would agree with adding more stuff to xlog.c

Well, they certainly don't belong in heapam.c... Got a better suggestion?

(I bumped into this again while working on the WAL format & API changes, 
which understandably rewrites those functions again. It seemed better to 
do this refactoring separately than include it in the huge patch.)

- Heikki




pgsql-hackers by date:

Previous
From: Fabien COELHO
Date:
Subject: Re: gaussian distribution pgbench -- splits v4
Next
From: Simon Riggs
Date:
Subject: Re: [COMMITTERS] pgsql: Move log_newpage and log_newpage_buffer to xlog.c.