Re: inherit support for foreign tables - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: inherit support for foreign tables
Date
Msg-id 53B2188B.4090302@lab.ntt.co.jp
Whole thread Raw
In response to Re: inherit support for foreign tables  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: inherit support for foreign tables  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
List pgsql-hackers
(2014/06/30 22:48), Tom Lane wrote:
> Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp> writes:
>> Done.  I think this is because create_foreignscan_plan() makes reference
>> to attr_needed, which isn't computed for inheritance children.
> 
> I wonder whether it isn't time to change that.  It was coded like that
> originally only because calculating the values would've been a waste of
> cycles at the time.  But this is at least the third place where it'd be
> useful to have attr_needed for child rels.

+1 for calculating attr_needed for child rels.  (I was wondering too.)

I'll create a separate patch for it.

Thanks,

Best regards,
Etsuro Fujita



pgsql-hackers by date:

Previous
From: Etsuro Fujita
Date:
Subject: Re: inherit support for foreign tables
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: inherit support for foreign tables