Re: Misleading comment in pg_upgrade.c - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Misleading comment in pg_upgrade.c
Date
Msg-id 5398147A-FE25-4844-8750-D47A804816F2@yesql.se
Whole thread Raw
In response to Misleading comment in pg_upgrade.c  (Julien Rouhaud <rjuju123@gmail.com>)
Responses Re: Misleading comment in pg_upgrade.c  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
> On 5 Dec 2019, at 10:17, Julien Rouhaud <rjuju123@gmail.com> wrote:

> While reading pg_upgrade code to restore the objects on the new
> cluster, I noticed that 5b570d771b8 didn't adjust the database name in
> the comments explaining the requirements for an extra "--clean" for
> template1 and postgres databases.  While it's true that both databases
> will already exist, I found it confusing to mention both names when
> only one is processed for each code path.

Agreed, I think this reads better.

cheers ./daniel




pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Update minimum SSL version
Next
From: Alvaro Herrera
Date:
Subject: Re: log bind parameter values on error