Re: Logical replication woes - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Logical replication woes
Date
Msg-id 5375CDE4.5050200@vmware.com
Whole thread Raw
In response to Re: Logical replication woes  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
On 05/15/2014 11:58 PM, Andres Freund wrote:
> On 2014-05-15 22:30:53 +0300, Heikki Linnakangas wrote:
>>> Attached patch fixes things, but I want to add some regression tests
>>> before commit.
>>
>> Looks good to me.
>
> Attached are two patches. One for the unitialized dbId/tsId issue; one
> for the decoding bug. The former should be backpatched.

Thanks, committed.

> Should you wonder about the slight reordering of the assignments in
> RecordTransactionCommitPrepared() - I've made it more similar to RecordTransactionCommit()
> to make it easier to see they are equivalent.

Makes sense.

- Heikki



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: 9.0 PDF build broken
Next
From: Craig Ringer
Date:
Subject: Re: SKIP LOCKED DATA (work in progress)