Re: buildfarm / handling (undefined) locales - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: buildfarm / handling (undefined) locales
Date
Msg-id 53738755.5070008@dunslane.net
Whole thread Raw
In response to Re: buildfarm / handling (undefined) locales  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 05/14/2014 11:02 AM, Tom Lane wrote:
> I wrote:
>> As far as Windows goes, we could certainly use #ifdef WIN32 to print
>> some different text, if anyone can write down what it should be.
> Some googling suggests that on Windows, setlocale pays no attention
> to environment variables but gets a value that the user can set via
> the Control Panel.

Indeed. There is a comment in plperl.c about that, because we have to 
deal with it in a somewhat ugly fashion.


> This probably means that an invalid setting is
> impossible, or at least that we have no clear idea how the user could
> screw it up.  So I'm thinking we do not need a Windows-specific
> phrasing of the message, until such time as we see evidence of how
> you could provoke this case on Windows.
>
>             

Right. I'd just leave Windows out of it for now.

cheers

andrew




pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: popen and pclose redefinitions causing many warning in Windows build
Next
From: Robert Haas
Date:
Subject: Re: 9.5: UPDATE/DELETE .. ORDER BY .. LIMIT ..