Re: do {} while (0) nitpick - Mailing list pgsql-hackers

From Tom Lane
Subject Re: do {} while (0) nitpick
Date
Msg-id 5365.1588606117@sss.pgh.pa.us
Whole thread Raw
In response to Re: do {} while (0) nitpick  (Jesse Zhang <sbjesse@gmail.com>)
List pgsql-hackers
Jesse Zhang <sbjesse@gmail.com> writes:
> On Fri, May 1, 2020 at 2:32 PM Tom Lane wrote:
>> Grepping showed me that there were some not-do-while macros that
>> also had trailing semicolons.  These seem just as broken, so I
>> fixed 'em all.

> I'm curious: *How* are you able to discover those occurrences with grep?

Um, well, actually, it was a little perl script with a state variable
to remember whether it was in a macro definition or not (set on seeing
a #define, unset when current line doesn't end with '\', complain if
set and line ends with ';').

            regards, tom lane



pgsql-hackers by date:

Previous
From: Jesse Zhang
Date:
Subject: Re: do {} while (0) nitpick
Next
From: "Bossart, Nathan"
Date:
Subject: race condition when writing pg_control