Postgres Pro
Downloads
Home   >   mailing lists

Re: A question about code in DefineRelation() - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: A question about code in DefineRelation()
Date
Msg-id 535636C5.7050301@lab.ntt.co.jp
Whole thread Raw
In response to A question about code in DefineRelation()  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Responses Re: A question about code in DefineRelation()  (Hadi Moshayedi <hadi@moshayedi.net>)
List pgsql-hackers
Tree view 
(2014/04/04 13:35), Etsuro Fujita wrote:
> If I understand correctly, foreign tables cannot have an OID column, but
> the following code in DefineRelation() assumes that foreign tables *can*
> have that coulum:

On second thought I noticed that that makes CREATE FOREIGN TABLE include
an OID column in newly-created foreign tables wrongly, when the
default_with_oids parameter is set to on.  Please find attached a patch.

Thanks,

Best regards,
Etsuro Fujita
Attachment

pgsql-hackers by date:

Previous
From: Hannu Krosing
Date:
Subject: Re: Clock sweep not caching enough B-Tree leaf pages?
Next
From: Jov
Date:
Subject: Re: AXLE Plans for 9.5 and 9.6