Re: Bug in GiST paring heap comparator - Mailing list pgsql-hackers

From Nikita Glukhov
Subject Re: Bug in GiST paring heap comparator
Date
Msg-id 53536807-784c-e029-6e92-6da802ab8d60@postgrespro.ru
Whole thread Raw
In response to Re: Bug in GiST paring heap comparator  (Nikita Glukhov <n.gluhov@postgrespro.ru>)
Responses Re: Bug in GiST paring heap comparator
List pgsql-hackers
On 20.09.2019 0:15, Nikita Glukhov wrote:
On 19.09.2019 22:14, Alexander Korotkov wrote:
Pushed.
Attached patch fixes premature xs_orderbynulls[] assignment.  The old value 
of NULL flag, not the new, should be checked before pfree()ing the old value.
Attached another one-line patch that fixes incorrect number of distances used 
in pairingheap_SpGistSearchItem_cmp():
-    for (i = 0; i < so->numberOfOrderBys; i++)
+    for (i = 0; i < so->numberOfNonNullOrderBys; i++)


This change was present in my original commit, but it seems to have been 
missed after the rebase.  Sorry.

--
Nikita Glukhov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: allocation limit for encoding conversion
Next
From: Ziga
Date:
Subject: Re: DROP SUBSCRIPTION with no slot