Postgres Pro
Downloads
Home   >   mailing lists

Re: Another assert failure from no-palloc-in-critical-sections - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Another assert failure from no-palloc-in-critical-sections
Date
Msg-id 53405726.90409@vmware.com
Whole thread Raw
In response to Another assert failure from no-palloc-in-critical-sections  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Another assert failure from no-palloc-in-critical-sections
List pgsql-hackers
Tree view 
On 04/05/2014 08:08 PM, Tom Lane wrote:
> I tried the test case given in
> http://www.postgresql.org/message-id/dafad644f268ce1503e1b8b682aae38a.squirrel@webmail.xs4all.nl
> on HEAD.  It asserted here:
>...
> #5  0x000000000046b92b in createPostingTree (index=0x7f1348ae31e0,
>      items=0x7f13343bb048, nitems=272428, buildStats=0x7fff1d835670)
>      at gindatapage.c:1739

Yep, that's a clear violation of the no-pallocs-in-critical-section 
rule. Thanks, fixed.

I'm surprised none of the existing regression tests caught that. 
Apparently none of them create a GIN index with enough duplicate keys 
that it would create a posting tree. I added one.

- Heikki

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: trgm regex index peculiarity
Next
From: Peter Geoghegan
Date:
Subject: Re: B-Tree support function number 3 (strxfrm() optimization)