On 03/27/2014 11:34 AM, Christoph Berg wrote:
> Re: Andrew Dunstan 2014-03-27 <53344465.6010401@dunslane.net>
>> On 03/27/2014 11:27 AM, Tom Lane wrote:
>>> Andrew Dunstan <andrew@dunslane.net> writes:
>>>> I guess we'd better add a make-contrib-check step to the buildfarm. I
>>>> was just prepping a release, so I'll delay that while I add this.
>>> BTW, won't that obsolete the need for the separate check-pg_upgrade
>>> step?
>> Yes, possibly.
>>
>> It helps if people bring to my attention changes in the build and test
>> infrastructure, sometimes I miss developments, as I did here.
> Why not "make check-world"? That should include everything, and
> doesn't need updating the scripts when something new gets included in
> PostgreSQL itself. The pg_upgrade test is included.
>
For several reasons. It's not simply a matter of running that command.
You also have to bundle up the various log files. Also, if all we do is
"check-world" and it fails that fact gives us relatively little
information, whereas if it passes "make check" but fails "make -C
contrib check" we'll have more information. So I'm not terribly excited
about combining steps too much.
cheers
andrew
