Re: libpq: Remove redundant null pointer checks before free() - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: libpq: Remove redundant null pointer checks before free()
Date
Msg-id 5333caf7-7667-bc58-0fd0-2e82eaf01967@enterprisedb.com
Whole thread Raw
In response to Re: libpq: Remove redundant null pointer checks before free()  (Michael Paquier <michael@paquier.xyz>)
Responses Re: libpq: Remove redundant null pointer checks before free()
List pgsql-hackers
On 17.06.22 05:25, Michael Paquier wrote:
> On Thu, Jun 16, 2022 at 10:07:33PM +0200, Peter Eisentraut wrote:
>> calls, where the "if" part is unnecessary.  This is of course pretty
>> harmless, but some functions like scram_free() and freePGconn() have become
>> so bulky that it becomes annoying.  So while I was doing some work in that
>> area I undertook to simplify this.
> Seems fine.  Would some of the buildfarm dinosaurs hiccup on that?
> gaur is one that comes into mind.

I'm pretty sure PostgreSQL code already depends on this behavior anyway. 
  The code just isn't consistent about it.



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Using PQexecQuery in pipeline mode produces unexpected Close messages
Next
From: Peter Eisentraut
Date:
Subject: Re: libpq: Remove redundant null pointer checks before free()