Re: set_ps_display during recovery - Mailing list pgsql-patches

From Tom Lane
Subject Re: set_ps_display during recovery
Date
Msg-id 5333.1191162507@sss.pgh.pa.us
Whole thread Raw
In response to Re: set_ps_display during recovery  (Simon Riggs <simon@2ndquadrant.com>)
Responses Re: set_ps_display during recovery
Re: set_ps_display during recovery
List pgsql-patches
Simon Riggs <simon@2ndquadrant.com> writes:
> On Sat, 2007-09-29 at 14:34 -0400, Tom Lane wrote:
>> Hmm, not right there, because we don't know that the file actually
>> exists yet.  Applied with modifications ...

> Double hmmm, that means when we are waiting for file X in pg_standby the
> ps display will still show "recovering X-1". I'd prefer to set ps before
> the call to RestoreArchivedFile(), since that is where the wait occurs.
> I got that wrong myself.

Well, if you think that's an important time component --- which it could
be in archive situations, I guess --- there should be a separate PS
display state for it.  Perhaps "fetching XXX" vs "restoring XXX"?

            regards, tom lane

pgsql-patches by date:

Previous
From: Michael Meskes
Date:
Subject: Re: ecpg thead-safe memory management + cleanup
Next
From: Simon Riggs
Date:
Subject: Re: set_ps_display during recovery