On 03/26/2014 09:21 AM, Peter Geoghegan wrote:
> It looks like a "recheck" stack variable isn't every being set within
> TS_execute_ternary() (which has a pointer to that variable on the
> stack) - ultimately, the checkcondition_gin() callback will set the
> flag, but only to 'true' (iff that's appropriate). When that doesn't
> happen, it just contains a garbage uninitialized value, and yet
> evidently control flow depends on that value.
>
> I propose that we initialize the variable to false, since there
> appears to be a tacit assumption that that is already the case, as
> with the plain consistent GIN support function in the same file.
> Attached patch does just that.
Yep, fixed. Thanks!
- Heikki
