Re: Review: plpgsql.extra_warnings, plpgsql.extra_errors - Mailing list pgsql-hackers

From Petr Jelinek
Subject Re: Review: plpgsql.extra_warnings, plpgsql.extra_errors
Date
Msg-id 532EF587.20705@2ndquadrant.com
Whole thread Raw
In response to Re: Review: plpgsql.extra_warnings, plpgsql.extra_errors  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: Review: plpgsql.extra_warnings, plpgsql.extra_errors  (Pavel Stehule <pavel.stehule@gmail.com>)
List pgsql-hackers

On 23/03/14 15:14, Pavel Stehule wrote:
> Review shadow_v6 patch
>
> I have only one objection - What I remember - more usual is using a list
> instead a bitmap for these purposes - typical is DefElem struct. Isn't
> it better?
>

To me it seemed that for similar use cases (list of boolean options) the 
bitmap is more common in the existing code, question might be if we go 
over the 32 bits any time soon which does not seem likely to me for the 
checks.


--  Petr Jelinek                  http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: Review: plpgsql.extra_warnings, plpgsql.extra_errors
Next
From: Guillaume Lelarge
Date:
Subject: Re: psql blows up on BOM character sequence