Re: pg_archivecleanup bug - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: pg_archivecleanup bug
Date
Msg-id 53289AD8.4060204@vmware.com
Whole thread Raw
In response to Re: pg_archivecleanup bug  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: pg_archivecleanup bug  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
On 03/18/2014 09:04 PM, Simon Riggs wrote:
> On 18 March 2014 18:55, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>
>> That said, I don't find comma expression to be particularly "not
>> simple".
>
> Maybe, but we've not used it before anywhere in Postgres, so I don't
> see a reason to start now. Especially since C is not the native
> language of many people these days and people just won't understand
> it.

Agreed. The psqlODBC code is littered with comma expressions, and the 
first time I saw it, it took me a really long time to figure out what 
"if (foo = malloc(...), foo) { } " meant. And I consider myself quite 
experienced with C.

- Heikki



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: B-tree descend for insertion locking
Next
From: Simon Riggs
Date:
Subject: Re: plpgsql.warn_shadow