On 03/14/2014 09:06 AM, Michael Paquier wrote:
> Hi all,
>
> I noticed that the regression tests of odbc do not take into account
> LDFLAGS at compilation, only CFLAGS actually. Having the possibility
> to use this flag is useful particularly when libodbc.so is in a
> customized path. Patch is attached.
Hmm. The regression test Makefile really ought to pick up the same
settings we use for the main makefile, so that if you do "./configure
--with-unixodbc=...", the regression tests are automatically built
against the same library.
I'm not sure what's the best way to achieve that. The regression
Makefile is currently completely separate from the automake system. We
could add "SUBDIRS=test" into Makefile.am, and then you could do "make
installcheck" from the top directory to run the regressions, and you
could use the LDFLAGS and other variables set by automake.
A problem with that is that the regression suite Makefile depends on
PostgreSQL's pg_config to find the pg_regress program. I guess the
proper solution would be to add an optional configure flag to provide a
path to pg_config. If pg_config is not found, then you couldn't run the
regression tests, but you could still build the driver without the
PostgreSQL header files etc.
- Heikki
