Re: pgsql: Default to hidden visibility for extension libraries where possi - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Default to hidden visibility for extension libraries where possi
Date
Msg-id 532024.1658111682@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Default to hidden visibility for extension libraries where possi  (Andres Freund <andres@anarazel.de>)
List pgsql-committers
Andres Freund <andres@anarazel.de> writes:
> I don't know how the configure exec bit got removed, shell history doesn't
> show anything odd in that regard. I do see a mistake in locally merging the
> symbol-visibility branch (leading to a crucial commit being missed). I do see
> in shell history that I ran check-world without a failure just before pushing,
> which should have shown the failure, but didn't.

check-world would not have re-run configure even if it was out of date
(only config.status), so that part of it's not so surprising.

> Definitely a brown paper bag moment.

We've all been there :-)

            regards, tom lane



pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: Default to hidden visibility for extension libraries where possi
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Convert macros to static inline functions (tupmacs.h)