Re: Terminating pg_basebackup background streamer - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Terminating pg_basebackup background streamer
Date
Msg-id 52F91A80.2010307@vmware.com
Whole thread Raw
In response to Terminating pg_basebackup background streamer  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Terminating pg_basebackup background streamer  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
On 02/09/2014 02:17 PM, Magnus Hagander wrote:
> If an error occurs in the foreground (backup) process of pg_basebackup, and
> we exit in a controlled way, the background process (streaming xlog
> process) would stay around and keep streaming.
>
> This can happen for example if disk space runs out and there is very low
> activity on the server. (If there is activity on the server, the background
> streamer will also run out of disk space and exit)
>
> Attached patch kills it off in disconnect_and_exit(), which seems like the
> right thing to do to me.
>
> Any objections to applying and backpatching that for the upcoming minor
> releases?

Do you get a different error message with this patch than before? Is the 
new one better than the old one?

- Heikki



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: jsonb and nested hstore
Next
From: Heikki Linnakangas
Date:
Subject: Re: Memory ordering issue in LWLockRelease, WakeupWaiters, WALInsertSlotRelease