On 02/10/2014 07:39 AM, Andres Freund wrote:
> On 2014-02-10 07:27:59 -0500, Andrew Dunstan wrote:
>> On 02/10/2014 05:05 AM, Andres Freund wrote:
>>> I'd suggest making the format discernible from possible different future
>>> formats, to allow introducing a proper binary at some later time. Maybe
>>> just send a int8 first, containing the format.
>>>
>> Teodor privately suggested something similar. I was thinking of just
>> sending a version byte, which for now would be '\x01'. An int8 seems like
>> more future-proofing provision than we really need.
> Hm. Isn't that just about the same? I was thinking of the c type int8,
> not the 64bit type. It seems cleaner to do a pg_sendint(..., 1, 1) than
> to do it manually inside the string.
OK, works for me. I'm tied up for a couple of days, will do this when
I'm back on deck.
cheers
andrew