Re: LDAP lookup of connection parameters - Mailing list pgsql-patches

From Albe Laurenz
Subject Re: LDAP lookup of connection parameters
Date
Msg-id 52EF20B2E3209443BC37736D00C3C13809A923B9@EXADV1.host.magwien.gv.at
Whole thread Raw
In response to LDAP lookup of connection parameters  ("Albe Laurenz" <all@adv.magwien.gv.at>)
Responses Re: LDAP lookup of connection parameters  (Bruce Momjian <bruce@momjian.us>)
List pgsql-patches
Bruce Momjian wrote:
>>>> This patch for libpq allows you to enter an LDAP URL in
>>>> pg_service.conf.
>>>> The URL will be queried and the resulting string(s) parsed for
>>>> keyword = value connection options.
>>>
>>> I have heavily modified your patch to be clearer.  Please
>>> review the
>>> attached version and test it to make sure it still works
>>> properly.
>
> Thanks for the review.  Updated patch attached.  Is that OK?

Mostly yes, and I must admit that the code has become more
readable. There were two syntax errors and some minor odds
and ends (partly my fault).

I have slightly changed your patch and submit it again
(diff the patches to see).

Thanks for the effort,
Laurenz Albe


Attachment

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: extension for sql update
Next
From: Simon Riggs
Date:
Subject: WAL file rotation/ XLog Switch