Re: jsonb and nested hstore - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: jsonb and nested hstore
Date
Msg-id 52EA9FE8.7000604@dunslane.net
Whole thread Raw
In response to Re: jsonb and nested hstore  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 01/30/2014 01:50 PM, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> On 01/30/2014 01:03 PM, Hannu Krosing wrote:
>>> On 01/30/2014 06:45 PM, Andrew Dunstan wrote:
>>>> We'd have to move that code from hstore to jsonb_support.c and then
>>>> make hstore refer to it.
>>> Or just copy it and leave hstore alone - the code duplication is not
>>> terribly huge here and hstore might still want to develop independently.
>> We have gone to great deal of trouble to make jsonb and nested hstore
>> more or less incarnations of the same thing. The new hstore relies
>> heavily on the new jsonb. So what you're suggesting is the opposite of
>> what's been developed these last months.
> If so, why would you be resistant to pushing more code out of hstore
> and into jsonb?
>


I'm not. Above I suggested exactly that. I was simply opposed to Hannu's 
suggestion that instead  of making hstore refer to the adopted code we 
maintain two copies of code that does essentially the same thing.

cheers

andrew



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: pgindent behavior we could do without
Next
From: Amit Kapila
Date:
Subject: Re: Performance Improvement by reducing WAL for Update Operation