Re: new json funcs - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: new json funcs
Date
Msg-id 52D82BB1.7040306@gmx.net
Whole thread Raw
In response to new json funcs  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: new json funcs  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
On 1/3/14, 9:00 PM, Andrew Dunstan wrote:
> 
> Here is a patch for the new json functions I mentioned a couple of
> months ago. These are:
> 
>     json_to_record
>     json_to_recordset
>     json_object
>     json_build_array
>     json_build_object
>     json_object_agg
> 
> So far there are no docs, but the way these work is illustrated in the
> regression tests - I hope to have docs within a few days.

Compiler warnings:

json.c: In function ‘json_object_two_arg’:
json.c:2210:5: warning: unused variable ‘count’ [-Wunused-variable]

jsonfuncs.c: In function ‘json_to_record’:
jsonfuncs.c:1955:16: warning: unused variable ‘tuple’ [-Wunused-variable]
jsonfuncs.c:1953:18: warning: variable ‘rec’ set but not used [-Wunused-but-set-variable]

Also, please run your patch through git diff --check.  I have noticed
that several of your patches have hilarious whitespace, maybe
something with your editor.



pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: Why conf.d should be default, and auto.conf and recovery.conf should be in it
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] Negative Transition Aggregate Functions (WIP)