Re: CREATE TABLESPACE SET - Mailing list pgsql-hackers

From Vik Fearing
Subject Re: CREATE TABLESPACE SET
Date
Msg-id 52BC6860.2070708@dalibo.com
Whole thread Raw
In response to Re: CREATE TABLESPACE SET  (David Fetter <david@fetter.org>)
List pgsql-hackers
On 12/26/2013 06:10 PM, David Fetter wrote:
> On Tue, Dec 24, 2013 at 07:25:01PM +0100, Vik Fearing wrote:
>> I was recently annoyed that I had to do
>>
>> CREATE TABLESPACE x LOCATION y;
>> ALTER TABLESPACE x SET (random_page_cost = z);
>>
>> The attached patch is a quick n' dirty extension to allow the SET
>> directly on the CREATE statement.
>>
>> CREATE TABLESPACE x LOCATION y SET (random_page_cost = z);
> That should probably be WITH instead of SET for consistency with other
> similar DDL.

It would make a simpler patch, too, but I wanted to be consistent with
ALTER TABLESPACE. I have no firm opinion on the subject, so I'll switch
it to WITH if no one else says anything.

-- 
Vik




pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Re: CREATE TABLESPACE SET
Next
From: Andrew Dunstan
Date:
Subject: Re: [BUGS] BUG #8676: Bug Money JSON