On 13.02.26 11:28, Jelte Fennema-Nio wrote:
> After discussing the topic in-person with Peter at FOSDEM. We agreed
> that the best road forward was to not bother with MSVC for now. No-one
> has actually expressed an interest in being able to build C++ extension
> using MSVC, and the effort to support it is both non-trivial and not
> without downsides to the rest of the codebase. We can always come back
> to this later, possibly requiring C++20 on MSVC.
I checked what would currently be missing to get MSVC supported.
Attached is the patch.
I think we should commit the pg_list.h changes, since the C-style
compound literals are not a C++ feature at all, and so without this MSVC
would never get supported. (Or you couldn't use PostgreSQL lists, which
would be very limiting.)
Here is a Compiler Explorer link that I used to check that the generated
code doesn't change: https://godbolt.org/z/ovKKzEfs6
The other changes deal with designated initializers and flexible array
members. These are not a blocker, since extension authors could deal
with them themselves by adding appropriate compiler options or similar.
