On 11/05/2013 10:31 PM, Tom Lane wrote:
> Peter Eisentraut <peter_e@gmx.net> writes:
>> Attached is a patch that
>> - Adds a .gitattributes file to configure appropriate whitespace checks
>> for git diff --check.
>> - Cleans up all whitespace errors found in this way in existing code.
>> Most of that is in files not covered by pgindent, some in new code since
>> the last pgindent.
>> This makes the entire tree git diff --check clean. After this, future
>> patches can be inspected for whitespace errors with git diff --check,
>> something that has been discussed on occasion.
> I always (well, almost always) do git diff --check, so making it stronger
> sounds good to me. But it sounds like this still leaves it to the
> committer to remember to run it. Can we do anything about that?
>
>
Personally I don't get the mania about trailing whitespace, but maybe
that's just me.
We could certainly implement a hook on the server that would reject
cases that fail this test, but we might find it hamstrings us a bit in
future. I'm not sure what else could be done to remedy committer
forgetfulness, though.
cheers
andrew
