Re: Commitfest II CLosed - Mailing list pgsql-hackers

From Josh Berkus
Subject Re: Commitfest II CLosed
Date
Msg-id 52656572.7060100@agliodbs.com
Whole thread Raw
In response to Re: Commitfest II CLosed  (David Fetter <david@fetter.org>)
Responses Re: Commitfest II CLosed
List pgsql-hackers
Andres,

> I find it utterly ridiculous to accuse the people that *do* reviews of
> not doing anything. By doing code-level reviews reviewers teach authors
> and bystanders more about the code. Which actually can increase the
> number of review(ers) and even committers in the long run.

It would be nice if it worked that way -- in a review system which
wasn't broken, it *should* work that way -- but a quick look at who's
been doing the reviews for the last 2 releases shows that we no longer
get new reviewers.

Don't get me wrong.  *you* are doing a ton of reviews, and if we had 20
people like you, then we wouldn't be talking about the review process at
all because everything would be done already.  But we don't.  And, for
that matter, I personally would love to see you not *need* to do so many
reviews, so that you could spend more time working on LSR.

> And no, not having an own solution, doesn't turn somebody elses
> non-solution into a solution.

Either you're proposing a solution, supporting someone else's solution,
or you're saying the problem isn't important.  There is no fourth
alternative.

-- 
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com



pgsql-hackers by date:

Previous
From: Boszormenyi Zoltan
Date:
Subject: Re: Commitfest II CLosed
Next
From: Merlin Moncure
Date:
Subject: Re: Who is pgFoundery administrator?