Re: [PATCH] Statistics collection for CLUSTER command - Mailing list pgsql-hackers

From Vik Fearing
Subject Re: [PATCH] Statistics collection for CLUSTER command
Date
Msg-id 525D2C8A.2030702@dalibo.com
Whole thread Raw
In response to Re: [PATCH] Statistics collection for CLUSTER command  (Satoshi Nagayasu <snaga@uptime.jp>)
Responses Re: [PATCH] Statistics collection for CLUSTER command  (Noah Misch <noah@leadboat.com>)
List pgsql-hackers
On 09/16/2013 08:26 AM, Satoshi Nagayasu wrote:
> (2013/08/08 20:52), Vik Fearing wrote:
>> As part of routine maintenance monitoring, it is interesting for us to
>> have statistics on the CLUSTER command (timestamp of last run, and
>> number of runs since stat reset) like we have for (auto)ANALYZE and
>> (auto)VACUUM.  Patch against today's HEAD attached.
>>
>> I would add this to the next commitfest but I seem to be unable to log
>> in with my community account (I can log in to the wiki).  Help
>> appreciated.
>
> I have reviewed the patch.

Thank you for your review.

> Succeeded to build with the latest HEAD, and passed the regression
> tests.
>
> Looks good enough, and I'd like to add a test case here, not only
> for the view definition, but also working correctly.
>
> Please take a look at attached one.

Looks good to me.  Attached is a rebased patch with those tests added.

--
Vik


Attachment

pgsql-hackers by date:

Previous
From: Vik Fearing
Date:
Subject: Re: SSL renegotiation
Next
From: Robert Haas
Date:
Subject: Re: INSERT...ON DUPLICATE KEY LOCK FOR UPDATE