Re: Signing off of patches (was Re: Not ready for 8.3) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Signing off of patches (was Re: Not ready for 8.3)
Date
Msg-id 5226.1179539951@sss.pgh.pa.us
Whole thread Raw
In response to Re: Signing off of patches (was Re: Not ready for 8.3)  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: Signing off of patches (was Re: Not ready for 8.3)  ("Karl O. Pinc" <kop@meme.com>)
Re: Signing off of patches (was Re: Not ready for 8.3)  (Neil Conway <neilc@samurai.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@commandprompt.com> writes:
> In order to make patch review more effective, perhaps we could use some
> tools to help us.  How about
> http://www.chipx86.com/blog/?p=222

I kinda think this is emphasizing the wrong end of the process.  "Code
everything, then ask for comments" is about as far away from the correct
mindset as one can readily get.

I'd like to see something that emphasizes review and feedback at the
stages of germinal idea, rough functional spec, implementation concept,
etc.  Reviewing the actual code is good too, but if that's the first
stage that you ask for help at, you are off in the wrong direction;
particularly so if you're a larval Postgres hacker.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Signing off of patches (was Re: Not ready for 8.3)
Next
From: "Karl O. Pinc"
Date:
Subject: Re: COPY into a view; help w. design & patch