Re: timeline signedness - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: timeline signedness
Date
Msg-id 520B843A.6090001@vmware.com
Whole thread Raw
In response to Re: timeline signedness  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: timeline signedness
List pgsql-hackers
On 13.08.2013 14:31, Peter Eisentraut wrote:
> On Wed, 2013-08-07 at 21:55 -0400, Peter Eisentraut wrote:
>> WAL timelines are unsigned 32-bit integers everywhere, except the
>> replication parser (replication/repl_gram.y and
>> replication/repl_scanner.l) treats them as signed 32-bit integers.  It's
>> obviously a corner case, but it would be prudent to be correct about
>> this.  It should be easy to fix in those grammar files.

+1

> Here is a patch to fix this.

If I'm reading this correctly, timeline 0 no longer throws an error with 
this patch.

- Heikki



pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: timeline signedness
Next
From: Merlin Moncure
Date:
Subject: Re: StrategyGetBuffer optimization, take 2