Re: SCSS Minor SonarQube fixes - Mailing list pgadmin-hackers
Thanks Aditys ! Updated patch accordingly.
Please do let me know if anything else.
From: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Date: Thursday, 27 August 2020 at 1:08 PM
To: Pramod Ahire <pramod.ahire@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>, Akshay Joshi <akshay.joshi@enterprisedb.com>
Subject: Re: SCSS Minor SonarQube fixes
Hi Pramod,
- font-family: monospace, monospace;
+ font-family: 'Roboto Mono', monospace;
We do not use Roboto for codemirror. Please revert the change. Regarding "monospace, monospace;", this is required by firefox.
On Thu, Aug 27, 2020 at 1:06 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya
Can you please review the patch?
On Thu, Aug 27, 2020 at 11:25 AM Pramod Ahire <pramod.ahire@enterprisedb.com> wrote:
Hi,
Please find attached minor fixes for sonarqube, which includes changes as below:
- Removed duplicate CSS declaration
- Added proper font with font-family
Please do let me know if any changes or missed.
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
--Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
Mobile: +91 976-788-8246
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Attachment
pgadmin-hackers by date: