Re: Patch to add support of "IF NOT EXISTS" to others "CREATE" statements - Mailing list pgsql-hackers

From Fabrízio de Royes Mello
Subject Re: Patch to add support of "IF NOT EXISTS" to others "CREATE" statements
Date
Msg-id 51F1C659.5040106@timbira.com.br
Whole thread Raw
In response to Re: Patch to add support of "IF NOT EXISTS" to others "CREATE" statements  (Karol Trzcionka <karlikt@gmail.com>)
Responses Re: Patch to add support of "IF NOT EXISTS" to others "CREATE" statements
List pgsql-hackers
On 24-07-2013 14:49, Karol Trzcionka wrote:
> Hello,
> patch works fine but is there any reason to comparing each ifNotExists
> in different way?
> i.e.
> ProcedureCreate
> if (!ifNotExists)
> ...
> else
> {
> ...
> return
> }
> ----
> TypeCreate
> if (ifNotExists)
> {
> ...
> return
> }
> ...
> ---
> Shouldn't it be more consistent?

Should be... I fix that in attached patch.

Regards,


--
    Fabrízio de Royes Mello         Timbira - http://www.timbira.com.br/
    PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Design proposal: fsync absorb linear slider
Next
From: Josh Berkus
Date:
Subject: Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])