Re: [v9.4] row level security - Mailing list pgsql-hackers

From Greg Smith
Subject Re: [v9.4] row level security
Date
Msg-id 51EF04EE.8010504@2ndQuadrant.com
Whole thread Raw
In response to Re: [v9.4] row level security  (Josh Berkus <josh@agliodbs.com>)
List pgsql-hackers
On 7/23/13 2:30 PM, Josh Berkus wrote:

> You know as well as me that, as consultants, we can get clients to pay for 10% extra time
> for review in the course of developing a feature

Before this number gets quoted anywhere, I think it's on the low side. 
I've spent a good bit of time measuring how much time it takes to do a 
fair offsetting review--one where you put as much time in as it takes to 
review your submission--and I keep getting numbers more in the 20 to 25% 
range.  The work involved to do a high quality review takes a while.

I happen to think the review structure is one of the most important 
components to PostgreSQL release quality.  It used to be a single level 
review with just the committers, now it's a two level structure.  The 
reason the Postgres code is so good isn't that the submitted development 
is inherently any better than other projects.  There's plenty of bogus 
material submitted here.  It's the high standards for review and commit 
that are the key filter.  The importance of the process to the result 
isn't weighed as heavily as I think it should be.

-- 
Greg Smith   2ndQuadrant US    greg@2ndQuadrant.com   Baltimore, MD
PostgreSQL Training, Services, and 24x7 Support www.2ndQuadrant.com



pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Re: Review: UNNEST (and other functions) WITH ORDINALITY
Next
From: Josh Berkus
Date:
Subject: Re: [v9.4] row level security