Re: Kudos for Reviewers -- straw poll - Mailing list pgsql-hackers

From Josh Berkus
Subject Re: Kudos for Reviewers -- straw poll
Date
Msg-id 51CB3D2C.60900@agliodbs.com
Whole thread Raw
In response to Kudos for Reviewers -- straw poll  (Josh Berkus <josh@agliodbs.com>)
Responses Re: Kudos for Reviewers -- straw poll  (Mark Kirkwood <mark.kirkwood@catalyst.net.nz>)
List pgsql-hackers
On 06/26/2013 12:02 PM, Alvaro Herrera wrote:
> See the entry for foreign key locks:
>
>   Prevent non-key-field row updates from locking foreign key rows (Álvaro
>   Herrera, Noah Misch, Andres Freund, Alexander Shulgin, Marti Raudsepp)
>
> I am the author of most of the code, yet I chose to add Noah and Andres
> because they contributed a huge amount of time to reviewing the patch,
> and Alex and Marti because they submitted some code.  They are all
> listed as coauthors, which seems a reasonable compromise to me.

What about the idea that reviewers who do code revision work, like in
your FK patch, get listed after the original patch author with the
patch, and reviewers do more lightweight reviews get listed at the
bottom of the release notes?  Seems fair to me.

--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com



pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Re: Add more regression tests for CREATE OPERATOR
Next
From: Josh Berkus
Date:
Subject: Re: Add more regression tests for dbcommands